Review Request 128976: [Contact List Applet] Drop custom compact representation

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128976/#review99359
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 21, 2016, 3:12 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128976/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 3:12 p.m.)
> 
> 
> Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> All it did was show an icon with a MouseArea, we can just set the plasmoid.icon instead
> 
> 
> Diffs
> -----
> 
>   contactlist/org.kde.ktp-contactlist/contents/ui/Presence.qml 575d97f 
>   contactlist/org.kde.ktp-contactlist/contents/ui/main.qml 43b8c8e 
> 
> Diff: https://git.reviewboard.kde.org/r/128976/diff/
> 
> 
> Testing
> -------
> 
> I now get proper hover effect on the tray icon and it still works because DefaultCompactRepresentation is also just an IconItem
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160921/5b3497fb/attachment.html>