Review Request 128976: [Contact List Applet] Drop custom compact representation

Kai Uwe Broulik kde at privat.broulik.de
Wed Sep 21 13:12:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128976/
-----------------------------------------------------------

Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson.


Repository: ktp-desktop-applets


Description
-------

All it did was show an icon with a MouseArea, we can just set the plasmoid.icon instead


Diffs
-----

  contactlist/org.kde.ktp-contactlist/contents/ui/Presence.qml 575d97f 
  contactlist/org.kde.ktp-contactlist/contents/ui/main.qml 43b8c8e 

Diff: https://git.reviewboard.kde.org/r/128976/diff/


Testing
-------

I now get proper hover effect on the tray icon and it still works because DefaultCompactRepresentation is also just an IconItem


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160921/7b8e7f31/attachment.html>


More information about the KDE-Telepathy mailing list