Review Request 128976: [Contact List Applet] Drop custom compact representation

Thu Sep 22 07:25:55 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128976/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 7:25 a.m.)

Status
------

This change has been marked as submitted.

Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson.

Changes
-------

Submitted with commit 2da2d251e26be335afd4df1877aaf503c24518dd by Kai Uwe Broulik to branch master.

Repository: ktp-desktop-applets

Description
-------

All it did was show an icon with a MouseArea, we can just set the plasmoid.icon instead

Diffs
-----

  contactlist/org.kde.ktp-contactlist/contents/ui/Presence.qml 575d97f 
  contactlist/org.kde.ktp-contactlist/contents/ui/main.qml 43b8c8e 

Diff: https://git.reviewboard.kde.org/r/128976/diff/

Testing
-------

I now get proper hover effect on the tray icon and it still works because DefaultCompactRepresentation is also just an IconItem

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160922/3d69b1cf/attachment-0001.html>