Review Request 126834: ktp-common-internals propagating presence model for status handler integration and global / multiple account presence fixes

James Smith smithjd15 at gmail.com
Thu Mar 17 07:18:25 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/
-----------------------------------------------------------

(Updated March 17, 2016, 7:18 a.m.)


Review request for Telepathy.


Changes
-------

1)Add a bool indicating the model has finished its initial load.
2)Stricter input checking in presenceModelChanged().
3)propagateNewPresenceChange -> propagateModelChange.
4)Minor debug capitalization change.
5)Const'ified presenceModelChanged QVariantList.


Repository: ktp-common-internals


Description
-------

New features:
-Simplified API, sends and collects changes over DBus.


Diffs (updated)
-----

  KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 
  KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 

Diff: https://git.reviewboard.kde.org/r/126834/diff/


Testing
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160317/8202ab0f/attachment.html>


More information about the KDE-Telepathy mailing list