Review Request 126834: ktp-common-internals propagating presence model for status handler integration and global / multiple account presence fixes

[James Smith]

> On March 13, 2016, 11:08 p.m., David Edmundson wrote:
> > KTp/Models/presence-model.cpp, line 86
> > <https://git.reviewboard.kde.org/r/126834/diff/2/?file=445116#file445116line86>
> >
> >     you should be able to have 
> >     presenceModelChanged(KTp::Presence, bool)
> >     
> >     and have it automatically cast as long as you have registered KTp::Presence as a DBus type

AFAIK with QDBusMessage, everything has to be in a QVariantList: https://techbase.kde.org/Development/Tutorials/D-Bus/Accessing_Interfaces.


> On March 13, 2016, 11:08 p.m., David Edmundson wrote:
> > KTp/Models/presence-model.cpp, line 231
> > <https://git.reviewboard.kde.org/r/126834/diff/2/?file=445116#file445116line231>
> >
> >     Personally I'd use two different DBus signals for add/remove.

With everything required in a QVariantList, it's easiest with less code duplication to send it all together.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/#review93493
-----------------------------------------------------------


On March 17, 2016, 7:18 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126834/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 7:18 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> New features:
> -Simplified API, sends and collects changes over DBus.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 
>   KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 
> 
> Diff: https://git.reviewboard.kde.org/r/126834/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160317/2b4cd7b1/attachment.html>