Review Request 126834: ktp-common-internals propagating presence model for status handler integration and global / multiple account presence fixes

[James Smith]

> On Feb. 29, 2016, 7:56 p.m., Martin Klapetek wrote:
> > Can you please be more specific with your descriptions? I have no clue what's the point of this change or what is it supposed to do/fix/prevent.
> 
> David Edmundson wrote:
>     I can explain this one at least. 
>     
>     I'll write it here to show what I need to see in a description:
>     
>     
>     The current code stores custom presences in a config file then sends a signal explicitly to the presence applet to reparse the config file.
>     
>     This isn't ideal because:
>      - the presence applet doesn't write back into the contact list
>      - we would have duplicate code if it did 
>      - we need read/write from krunner as well now that also has presence message support
>     
>     This code moves the propogating changes to be internal to the model shared by all the components with add/remove signals for the new messages.

Sorry, this was a rebase mistake. The comment is now set in #123482, and ignored with this patchset.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/#review92932
-----------------------------------------------------------


On March 17, 2016, 7:18 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126834/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 7:18 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> New features:
> -Simplified API, sends and collects changes over DBus.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 
>   KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 
> 
> Diff: https://git.reviewboard.kde.org/r/126834/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160317/8e499ce5/attachment.html>