Review Request 123187: Don't return empty menu on offline contacts

Martin Klapetek martin.klapetek at gmail.com
Mon Mar 30 17:02:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123187/
-----------------------------------------------------------

(Updated March 30, 2015, 5:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Changes
-------

Submitted with commit 62967536fb8259d1d5660b0cec44142f35bcbb40 by Martin Klapetek to branch Applications/15.04.


Repository: ktp-contact-list


Description
-------

Some actions can be triggered even when the contact is offline, so I've changed it to check for things properly rather than simply returning null menu.


Diffs
-----

  context-menu.cpp b193408 

Diff: https://git.reviewboard.kde.org/r/123187/diff/


Testing
-------

Works nicely.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150330/db6f5ab1/attachment-0001.html>


More information about the KDE-Telepathy mailing list