Review Request 123187: Don't return empty menu on offline contacts

Aleix Pol Gonzalez aleixpol at kde.org
Mon Mar 30 15:51:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123187/#review78225
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On March 30, 2015, 5:35 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123187/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 5:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Some actions can be triggered even when the contact is offline, so I've changed it to check for things properly rather than simply returning null menu.
> 
> 
> Diffs
> -----
> 
>   context-menu.cpp b193408 
> 
> Diff: https://git.reviewboard.kde.org/r/123187/diff/
> 
> 
> Testing
> -------
> 
> Works nicely.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150330/2a366029/attachment-0001.html>


More information about the KDE-Telepathy mailing list