Review Request 123238: Extend the unit tests and fix a boog they uncover

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123238/
-----------------------------------------------------------

(Updated April 3, 2015, 4:23 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Changes
-------

Submitted with commit 2e6f9f89a5a224e510271d24dc8c4870b59e22da by Martin Klapetek to branch master.


Repository: kpeople


Description
-------

I've been investigating a bug in contact list when unmerging a single contact from a Person would leave empty rows (and originally would crash), turns out that removing Contact from Person does not emit the rows removed signal and so the model then tries to access invalid contact (and we get "out of bounds" assert).


Diffs
-----

  autotests/fakecontactsource.cpp 3cbeb89 
  autotests/personsmodeltest.h 17fc290 
  autotests/personsmodeltest.cpp c2a981e 
  src/personsmodel.cpp 716070c 

Diff: https://git.reviewboard.kde.org/r/123238/diff/


Testing
-------

Tests pass, bug is fixed.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150403/6cbfc43c/attachment.html>