Review Request 123238: Extend the unit tests and fix a boog they uncover

[Martin Klapetek]

> On April 3, 2015, 1:22 p.m., David Edmundson wrote:
> > +1

Given there is frameworks tagging tomorrow, I'll ship this now so it gets to the 5.9 release (and can be out when KTp comes out).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123238/#review78434
-----------------------------------------------------------


On April 3, 2015, 1:18 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123238/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 1:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> I've been investigating a bug in contact list when unmerging a single contact from a Person would leave empty rows (and originally would crash), turns out that removing Contact from Person does not emit the rows removed signal and so the model then tries to access invalid contact (and we get "out of bounds" assert).
> 
> 
> Diffs
> -----
> 
>   autotests/fakecontactsource.cpp 3cbeb89 
>   autotests/personsmodeltest.h 17fc290 
>   autotests/personsmodeltest.cpp c2a981e 
>   src/personsmodel.cpp 716070c 
> 
> Diff: https://git.reviewboard.kde.org/r/123238/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, bug is fixed.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20150403/2fa44a65/attachment.html>