Review Request 117128: Catch Akonadi errors and emit finished if akonadi is broken

[Dan Vrátil]

> On March 28, 2014, 4:09 p.m., Martin Klapetek wrote:
> > src/plugins/akonadi/akonadidatasource.cpp, line 170
> > <https://git.reviewboard.kde.org/r/117128/diff/1/?file=257885#file257885line170>
> >
> >     Should we catch more states here? Like "stopping" or "not running"?
> >     
> >     Oh and if( --> if (

"Stopping" is a transitional state and all jobs will be terminated automatically when it goes to "Not Running". When you start a job and the server is in "Not Running" state, it will be autostarted.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117128/#review54454
-----------------------------------------------------------


On March 27, 2014, 10:03 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117128/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 10:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Catch Akonadi errors and emit finished if akonadi is broken
> 
> 
> Diffs
> -----
> 
>   src/plugins/akonadi/akonadidatasource.cpp 2f006c9 
> 
> Diff: https://git.reviewboard.kde.org/r/117128/diff/
> 
> 
> Testing
> -------
> 
> When akonadi is working it works the same as before.
> I can't really test akonadi being broken. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/2acdc79b/attachment.html>