Review Request 117128: Catch Akonadi errors and emit finished if akonadi is broken

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117128/#review54472
-----------------------------------------------------------


You should also call emitInitialFetchComplete() when the server is already in Broken state when you start KTp.


src/plugins/akonadi/akonadidatasource.cpp
<https://git.reviewboard.kde.org/r/117128/#comment38110>

    Don't start Akonadi explicitely. It will be started by the first job that needs it.



src/plugins/akonadi/akonadidatasource.cpp
<https://git.reviewboard.kde.org/r/117128/#comment38118>

    You must make sure not to call emitInitialFetchComplete() twice. When the initial fetch succeeds the first time and then Akonadi gets broken for any reason, this code would emit the signal again and hit an assert somewhere in the PersonsModel


- Dan Vrátil


On March 27, 2014, 10:03 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117128/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 10:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Catch Akonadi errors and emit finished if akonadi is broken
> 
> 
> Diffs
> -----
> 
>   src/plugins/akonadi/akonadidatasource.cpp 2f006c9 
> 
> Diff: https://git.reviewboard.kde.org/r/117128/diff/
> 
> 
> Testing
> -------
> 
> When akonadi is working it works the same as before.
> I can't really test akonadi being broken. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/914006c2/attachment-0001.html>