Review Request 117128: Catch Akonadi errors and emit finished if akonadi is broken
Martin Klapetek
martin.klapetek at gmail.com
Fri Mar 28 15:09:48 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117128/#review54454
-----------------------------------------------------------
src/plugins/akonadi/akonadidatasource.cpp
<https://git.reviewboard.kde.org/r/117128/#comment38096>
Should we catch more states here? Like "stopping" or "not running"?
Oh and if( --> if (
- Martin Klapetek
On March 27, 2014, 10:03 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117128/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 10:03 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: libkpeople
>
>
> Description
> -------
>
> Catch Akonadi errors and emit finished if akonadi is broken
>
>
> Diffs
> -----
>
> src/plugins/akonadi/akonadidatasource.cpp 2f006c9
>
> Diff: https://git.reviewboard.kde.org/r/117128/diff/
>
>
> Testing
> -------
>
> When akonadi is working it works the same as before.
> I can't really test akonadi being broken.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140328/3353f0eb/attachment.html>
More information about the KDE-Telepathy
mailing list