Review Request 112986: Use nco:contactUID instead of nco:imID to identify a contact [part 1/2]

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112986/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 2:15 p.m.)


Status
------

This change has been discarded.


Review request for Telepathy, David Edmundson, Martin Klapetek, and Vishesh Handa.


Repository: libkpeople


Description
-------

Add a new role "ContactUIDRole" to return nco:contactUID and use nco:contactUID instead of nco:imID to identify a contact.
This is necessary because the imID is not unique, for example if I have 2 accounts, both friends of some contact, the imID of the contact is the same.


Diffs
-----

  src/personsmodel.cpp 5865740477c6aaabc1117808cde8f649eb54c8ef 
  src/personsmodel.h b7da6e5aa922275c16314c1ad64d929d7b7b9582 
  src/persondata.cpp 8fa4f0daff087bf3f53c7550fd04a8bbd3642f82 
  src/datasourcewatcher_p.h 0018c69bc9a7ae5a99e70d00c95461d104e79d06 
  src/contactitem.cpp e100a31ac53bcb0f2a722cb1cf5ce789a29f6866 

Diff: https://git.reviewboard.kde.org/r/112986/diff/


Testing
-------

Run unit test, tested with contact list


Thanks,

Daniele E. Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140116/27da8405/attachment.html>