<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112986/">https://git.reviewboard.kde.org/r/112986/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson, Martin Klapetek, and Vishesh Handa.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2014, 2:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a new role "ContactUIDRole" to return nco:contactUID and use nco:contactUID instead of nco:imID to identify a contact.
This is necessary because the imID is not unique, for example if I have 2 accounts, both friends of some contact, the imID of the contact is the same.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run unit test, tested with contact list</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/personsmodel.cpp <span style="color: grey">(5865740477c6aaabc1117808cde8f649eb54c8ef)</span></li>
<li>src/personsmodel.h <span style="color: grey">(b7da6e5aa922275c16314c1ad64d929d7b7b9582)</span></li>
<li>src/persondata.cpp <span style="color: grey">(8fa4f0daff087bf3f53c7550fd04a8bbd3642f82)</span></li>
<li>src/datasourcewatcher_p.h <span style="color: grey">(0018c69bc9a7ae5a99e70d00c95461d104e79d06)</span></li>
<li>src/contactitem.cpp <span style="color: grey">(e100a31ac53bcb0f2a722cb1cf5ce789a29f6866)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112986/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>