Review Request 117850: Use QPixmap for loading images

David Edmundson david at davidedmundson.co.uk
Mon Apr 28 20:48:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117850/
-----------------------------------------------------------

Review request for Telepathy.


Repository: libkpeople


Description
-------

Use QPixmap for loading images

QPixmap has an implit cache when loading from a path. QImage does not.
This saves a lot of QImage::load calls.

As it goes via QVariant .toImage and .toPixmap work the same as before.
ktp-contactlist used pixmap anyway.


Diffs
-----

  src/personsmodel.cpp 9575d46 

Diff: https://git.reviewboard.kde.org/r/117850/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140428/34067315/attachment.html>


More information about the KDE-Telepathy mailing list