Review Request 117809: Don't disable input box when disconnected
Ahmed I. Khalil
ahmedibrahimkhali at gmail.com
Wed Apr 30 22:45:48 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117809/
-----------------------------------------------------------
(Updated May 1, 2014, 12:45 a.m.)
Review request for Telepathy.
Changes
-------
-Changed the string to "Your message cannot be sent because the account <accountname> is offline. Please try again when the account is connected again."
-Changed the "Switch Online" button to "Connect <accountname>"
Bugs: 320385
http://bugs.kde.org/show_bug.cgi?id=320385
Repository: ktp-text-ui
Description
-------
Don't disable the input box when disconnected and the user sends a message a status message is added saying "Your message was not sent because you are offline" and the message box is not cleared.
Diffs (updated)
-----
lib/chat-widget.h 028ece4
lib/chat-widget.cpp c4f2ea5
Diff: https://git.reviewboard.kde.org/r/117809/diff/
Testing
-------
Turned the connection offline, tried to send a message, a status message is added as expected. Then turned the status to online the message is still there and when pressed return the message is sent normally.
File Attachments
----------------
Message Widget with "Switch Online" button
https://git.reviewboard.kde.org/media/uploaded/files/2014/04/29/6139c0a4-c926-4c13-98cb-017fedab3155__Disconnected_with_online_button.png
Message Widget without the "Switch Online" button
https://git.reviewboard.kde.org/media/uploaded/files/2014/04/29/9b46448b-3337-45ff-a336-df1f3ffe125e__Disconnected_with_no_online_button.png
Thanks,
Ahmed I. Khalil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140430/12334fb1/attachment.html>
More information about the KDE-Telepathy
mailing list