Review Request 117850: Use QPixmap for loading images

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117850/#review56798
-----------------------------------------------------------



src/personsmodel.cpp
<https://git.reviewboard.kde.org/r/117850/#comment39645>

    Note that KABC::Adressee actually uses QImage for person.photo() --> now the question is - is this image always loaded when person.photo() is called? Otherwise the always-cached-QPixmap would save only so much...
    
    I'm also wondering why the PIM people chose QImage over the implicitly cached QPixmap


- Martin Klapetek


On April 28, 2014, 10:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117850/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 10:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Use QPixmap for loading images
> 
> QPixmap has an implit cache when loading from a path. QImage does not.
> This saves a lot of QImage::load calls.
> 
> As it goes via QVariant .toImage and .toPixmap work the same as before.
> ktp-contactlist used pixmap anyway.
> 
> 
> Diffs
> -----
> 
>   src/personsmodel.cpp 9575d46 
> 
> Diff: https://git.reviewboard.kde.org/r/117850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140428/5695fd28/attachment-0001.html>