Review Request 117366: Use onRequestedPresenceChanged in the contact list

[James Smith]

> On April 7, 2014, 8:37 a.m., James Smith wrote:
> >

I think that the perfect situation would be for the presence chooser to properly fall back to off-line, thereby disabling the status message editor on the chooser in the process, but still allowing presence status message changes in the presence chooser's status message dialog editor. requestedPresenceChanged() reporting an offline state with no accounts enabled (or all accounts disabled) would allow us to ignore the presence chooser's problem setting status messages where the accounts are off-line but the chooser doesn't get a final off-line from the account manager, erroneously allowing user-entry of status messages on the chooser's editor in the last presence that was set by the user prior to the accounts becoming disabled.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117366/#review55130
-----------------------------------------------------------


On April 5, 2014, 10:56 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117366/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 10:56 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Use requestedPresenceChanged in the presence chooser, as well as calling onPresenceChanged after every selectable option that can trigger config changes or presence changes in onUserActivatedComboChange. This improves the contact list interaction with #116940. The selected presence is instantly activated instead of the last selected user presence when deactivating the nowPlaying status message plugin.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 64c5966 
> 
> Diff: https://git.reviewboard.kde.org/r/117366/diff/
> 
> 
> Testing
> -------
> 
> Compile, runtime
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140407/c3a1830c/attachment.html>