Review Request 117366: Use onRequestedPresenceChanged in the contact list

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117366/#review55130
-----------------------------------------------------------



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/117366/#comment38434>

    requestedPresenceChanged doesn't  properly change the user-facing presence when all accounts are disabled while the presence chooser is not in an off-line state.



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/117366/#comment38433>

    Using onPresenceChanged effectively disables the presence chooser quick status  message editor when there are no enabled accounts, and also effectively locks the chooser to the last presence when all the accounts are disabled. The benefits however for on-line accounts are quicker changing to the selected presence (saving a click), and the status message dialog editor is still available for bulk status message changing if all accounts are off-line.


- James Smith


On April 5, 2014, 10:56 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117366/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 10:56 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Use requestedPresenceChanged in the presence chooser, as well as calling onPresenceChanged after every selectable option that can trigger config changes or presence changes in onUserActivatedComboChange. This improves the contact list interaction with #116940. The selected presence is instantly activated instead of the last selected user presence when deactivating the nowPlaying status message plugin.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 64c5966 
> 
> Diff: https://git.reviewboard.kde.org/r/117366/diff/
> 
> 
> Testing
> -------
> 
> Compile, runtime
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140407/f78294ff/attachment.html>