Review Request 117366: Use onRequestedPresenceChanged in the contact list

James Smith smithjd15 at gmail.com
Tue Apr 8 11:01:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117366/
-----------------------------------------------------------

(Updated April 8, 2014, 11:01 a.m.)


Review request for Telepathy.


Changes
-------

A hybrid approach that fixes the offline-account presence affinity.


Repository: ktp-contact-list


Description
-------

Use requestedPresenceChanged in the presence chooser, as well as calling onPresenceChanged after every selectable option that can trigger config changes or presence changes in onUserActivatedComboChange. This improves the contact list interaction with #116940. The selected presence is instantly activated instead of the last selected user presence when deactivating the nowPlaying status message plugin.


Diffs (updated)
-----

  global-presence-chooser.cpp 2047473 

Diff: https://git.reviewboard.kde.org/r/117366/diff/


Testing
-------

Compile, runtime


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140408/ba103f7f/attachment.html>


More information about the KDE-Telepathy mailing list