Review Request 117366: Use onRequestedPresenceChanged in the contact list

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117366/#review55058
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On April 5, 2014, 10:56 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117366/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 10:56 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Use requestedPresenceChanged in the presence chooser, as well as calling onPresenceChanged after every selectable option that can trigger config changes or presence changes in onUserActivatedComboChange. This improves the contact list interaction with #116940. The selected presence is instantly activated instead of the last selected user presence when deactivating the nowPlaying status message plugin.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 64c5966 
> 
> Diff: https://git.reviewboard.kde.org/r/117366/diff/
> 
> 
> Testing
> -------
> 
> Compile, runtime
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140406/49bdb9c5/attachment.html>