Review Request 117165: Separate the editing of presence type and message in the Edit custom presence dialog

[Siddhartha Sahu]

> On March 30, 2014, 3:58 p.m., Martin Klapetek wrote:
> > Hint (in addition to the previous comment): void CustomPresenceDialog::comboboxIndexChanged(const QString& text)
> 
> Siddhartha Sahu wrote:
>     In both comboboxIndexChanged and presenceMessageTextChanged, the "Set custom busy message..." (eg.) text is received on changing the combo index. Am I missing something?
> 
> Martin Klapetek wrote:
>     Yes, you are :)
>     
>     Inside comboboxIndexChanged() we do this:
>     
>         m_statusMessage->lineEdit()->setText(QString());
>         m_statusMessage->lineEdit()->setPlaceholderText(text);
>     
>     ...if you store the written string in presenceMessageTextChanged() somewhere, then you can replace the line^ setText(QString()) with setText(myStoredString) and it will put the string back; you might also want to switch the order of those lines and check if the stored string is not empty first

comboboxIndexChanged also triggers presenceMessageTextChanged, and the saved message gets replaced. How to resolve this using same KComboBox?

One way is to initially set a blank string, and add the message to each index on every presenceMessageTextChanged. A bit hackish?


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117165/#review54582
-----------------------------------------------------------


On March 30, 2014, 1:52 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117165/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 1:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Before this, changing the presence type removed the already typed in text.
> 
> 
> Diffs
> -----
> 
>   dialogs/custom-presence-dialog.h 4c2cca63fa077d28f567ace54adcf8373810a5e0 
>   dialogs/custom-presence-dialog.cpp 5e7b76eb084c5cb1dbf834228ee9bfcf3ae271d4 
> 
> Diff: https://git.reviewboard.kde.org/r/117165/diff/
> 
> 
> Testing
> -------
> 
> Adding and removing presences work as before.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/29/81e4f307-b0e7-499c-8b2f-d51a3cdc19e8__ss.png
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140402/31488135/attachment.html>