Review Request 117180: Use SettingsKcmDialog from K-C-I

[Siddhartha Sahu]

> On March 30, 2014, 3:42 p.m., Martin Klapetek wrote:
> > contact-list-widget.cpp, line 213
> > <https://git.reviewboard.kde.org/r/117180/diff/1/?file=258134#file258134line213>
> >
> >     Space between arguments; this is also horribly wrong (I know it's not your code), can we make it autosize and not hardcode to magic values?

Do we use something like this?

QDesktopWidget widget;
QRect mainScreenSize = widget.availableGeometry(widget.primaryScreen());
dialog->resize((int)mainScreenSize->width()*0.6,(int)mainScreenSize->height()*0.6);


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117180/#review54581
-----------------------------------------------------------


On March 30, 2014, 1:35 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117180/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 1:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Ported from ktp-contact-list's contact-list-widget.cpp
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp ffae7bf2acdfa54932e6bc1ba3724f5fae808223 
> 
> Diff: https://git.reviewboard.kde.org/r/117180/diff/
> 
> 
> Testing
> -------
> 
> Settings dialog successfully opens
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140402/a0304cde/attachment.html>