<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117165/">https://git.reviewboard.kde.org/r/117165/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 30th, 2014, 3:58 p.m. IST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hint (in addition to the previous comment): void CustomPresenceDialog::comboboxIndexChanged(const QString& text)</pre>
</blockquote>
<p>On March 30th, 2014, 8:37 p.m. IST, <b>Siddhartha Sahu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In both comboboxIndexChanged and presenceMessageTextChanged, the "Set custom busy message..." (eg.) text is received on changing the combo index. Am I missing something?</pre>
</blockquote>
<p>On March 30th, 2014, 9:47 p.m. IST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, you are :)
Inside comboboxIndexChanged() we do this:
m_statusMessage->lineEdit()->setText(QString());
m_statusMessage->lineEdit()->setPlaceholderText(text);
...if you store the written string in presenceMessageTextChanged() somewhere, then you can replace the line^ setText(QString()) with setText(myStoredString) and it will put the string back; you might also want to switch the order of those lines and check if the stored string is not empty first</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">comboboxIndexChanged also triggers presenceMessageTextChanged, and the saved message gets replaced. How to resolve this using same KComboBox?
One way is to initially set a blank string, and add the message to each index on every presenceMessageTextChanged. A bit hackish?</pre>
<br />
<p>- Siddhartha</p>
<br />
<p>On March 30th, 2014, 1:52 a.m. IST, Siddhartha Sahu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Siddhartha Sahu.</div>
<p style="color: grey;"><i>Updated March 30, 2014, 1:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-contact-list
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before this, changing the presence type removed the already typed in text.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding and removing presences work as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dialogs/custom-presence-dialog.h <span style="color: grey">(4c2cca63fa077d28f567ace54adcf8373810a5e0)</span></li>
<li>dialogs/custom-presence-dialog.cpp <span style="color: grey">(5e7b76eb084c5cb1dbf834228ee9bfcf3ae271d4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117165/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/29/81e4f307-b0e7-499c-8b2f-d51a3cdc19e8__ss.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>