Review Request 103811: Enhance icon behaviour of text ui

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/103811/
-----------------------------------------------------------

(Updated April 2, 2014, 2:50 p.m.)


Status
------

This change has been discarded.


Review request for Telepathy and David Edmundson.


Repository: ktp-text-ui


Description
-------

We spoke about this some time ago on irc...
Currently the behaviour of the main icon is not really useful.
With this patch the icon will change when you receive a message, and it will make it easier to understand that you have an unread message (at the moment if you don't notice the blinking app in the task manager it's not easy to spot)

This set of patches do the following (you may agree or disagree with some of them, I'm not really convinced by all of them, so let's discuss it)

1) Main icon is always the same (telepathy-kde) and adds an overlay when a new messages is received
2) Tab bar is always shown
3) The user icon has an overlay if the user is typing or if there is an unread message (unread takes precedence over typing because I tried with 2 overlays and it looks horrible)
4) Give the precedence to new messages over typing for name colour

branch is here: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Fddomenichelli%2Fktp-text-ui.git&a=shortlog&h=refs/heads/iconEnhancement


Diffs
-----

  app/chat-window.h 4afa8a1b8d6ee92f75197bf57895f3a57526c516 
  app/chat-window.cpp 59db66db442dffbb3352ca1c66133f1c461d1b59 
  lib/chat-widget.cpp 872de0299cd0eb11d61f9bab6ba12fe493336207 

Diff: https://git.reviewboard.kde.org/r/103811/diff/


Testing
-------


Thanks,

Daniele E. Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140402/8124b83a/attachment.html>