Review Request 113842: Fix sorting in declarative contacts-model

Siddhartha Sahu sh.siddhartha at gmail.com
Wed Apr 2 14:52:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113842/
-----------------------------------------------------------

(Updated April 2, 2014, 2:52 p.m.)


Status
------

This change has been discarded.


Review request for Telepathy.


Repository: ktp-common-internals


Description
-------

This is working only sporadically.

Is it because of setSourceModel being called from elsewhere too.
The model seems to contain all the role names even when the sorting fails (in which case sorting seems random)


Diffs
-----

  KTp/Models/contacts-model.h e6fb7b1 
  KTp/Models/contacts-model.cpp 0f69eb5 

Diff: https://git.reviewboard.kde.org/r/113842/diff/


Testing
-------

Not working perfectly yet.


Thanks,

Siddhartha Sahu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140402/acb31bd6/attachment.html>


More information about the KDE-Telepathy mailing list