<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/103811/">https://git.reviewboard.kde.org/r/103811/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated April 2, 2014, 2:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We spoke about this some time ago on irc...
Currently the behaviour of the main icon is not really useful.
With this patch the icon will change when you receive a message, and it will make it easier to understand that you have an unread message (at the moment if you don't notice the blinking app in the task manager it's not easy to spot)
This set of patches do the following (you may agree or disagree with some of them, I'm not really convinced by all of them, so let's discuss it)
1) Main icon is always the same (telepathy-kde) and adds an overlay when a new messages is received
2) Tab bar is always shown
3) The user icon has an overlay if the user is typing or if there is an unread message (unread takes precedence over typing because I tried with 2 overlays and it looks horrible)
4) Give the precedence to new messages over typing for name colour
branch is here: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Fddomenichelli%2Fktp-text-ui.git&a=shortlog&h=refs/heads/iconEnhancement</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.h <span style="color: grey">(4afa8a1b8d6ee92f75197bf57895f3a57526c516)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(59db66db442dffbb3352ca1c66133f1c461d1b59)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(872de0299cd0eb11d61f9bab6ba12fe493336207)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/103811/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>