Review Request 113836: Backlog loading in declarative message model

Siddhartha Sahu sh.siddhartha at gmail.com
Fri Nov 15 09:54:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113836/
-----------------------------------------------------------

(Updated Nov. 15, 2013, 3:24 p.m.)


Review request for Telepathy.


Changes
-------

Add check for repeat message loading, optimize insertRows


Repository: ktp-common-internals


Description
-------

This loads last 'n' messages into the message model when a chat is started.

For now, KTp-text-ui's configuration is being used to determine 'n'. Where will KTp-Active's configuration be stored? 


Diffs (updated)
-----

  KTp/Declarative/CMakeLists.txt 7208fd2 
  KTp/Declarative/messages-model.h 24d2cb8 
  KTp/Declarative/messages-model.cpp 601c418 
  KTp/Logger/CMakeLists.txt 9bf6c68 
  KTp/Logger/scrollback-manager.h PRE-CREATION 
  KTp/Logger/scrollback-manager.cpp PRE-CREATION 
  data/ktelepathy.notifyrc 6188e3f 

Diff: http://git.reviewboard.kde.org/r/113836/diff/


Testing
-------

Works


Thanks,

Siddhartha Sahu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131115/c78504ae/attachment.html>


More information about the KDE-Telepathy mailing list