Review Request 113836: Backlog loading in declarative message model

David Edmundson david at davidedmundson.co.uk
Fri Nov 15 09:59:19 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113836/#review43709
-----------------------------------------------------------

Ship it!



data/ktelepathy.notifyrc
<http://git.reviewboard.kde.org/r/113836/#comment31405>

    Make sure this doesn't happen when you commit.
    
    For now I think it's just your branch being behind master when you make your diff.
    
    Just run qgit (or git log or something) before you push to make sure everything is ok.


- David Edmundson


On Nov. 15, 2013, 9:54 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113836/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 9:54 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This loads last 'n' messages into the message model when a chat is started.
> 
> For now, KTp-text-ui's configuration is being used to determine 'n'. Where will KTp-Active's configuration be stored? 
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/CMakeLists.txt 7208fd2 
>   KTp/Declarative/messages-model.h 24d2cb8 
>   KTp/Declarative/messages-model.cpp 601c418 
>   KTp/Logger/CMakeLists.txt 9bf6c68 
>   KTp/Logger/scrollback-manager.h PRE-CREATION 
>   KTp/Logger/scrollback-manager.cpp PRE-CREATION 
>   data/ktelepathy.notifyrc 6188e3f 
> 
> Diff: http://git.reviewboard.kde.org/r/113836/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131115/de81760b/attachment.html>


More information about the KDE-Telepathy mailing list