Review Request 113836: Backlog loading in declarative message model

[David Edmundson]

> On Nov. 13, 2013, 4:27 p.m., David Edmundson wrote:
> > KTp/Declarative/messages-model.cpp, line 134
> > <http://git.reviewboard.kde.org/r/113836/diff/2/?file=213935#file213935line134>
> >
> >     One bug left.
> >     
> >     If we set a text channel
> >     
> >     We go offline and online again - we call setTextChannel again.
> >     
> >     We reload the scrollback and insert things twice.
> 
> Siddhartha Sahu wrote:
>     So we use a boolean variable to keep track of whether it has already been loaded?

sounds good.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113836/#review43609
-----------------------------------------------------------


On Nov. 13, 2013, 4 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113836/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 4 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This loads last 'n' messages into the message model when a chat is started.
> 
> For now, KTp-text-ui's configuration is being used to determine 'n'. Where will KTp-Active's configuration be stored? 
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/CMakeLists.txt 7208fd2 
>   KTp/Declarative/messages-model.h 24d2cb8 
>   KTp/Declarative/messages-model.cpp 601c418 
>   KTp/Logger/CMakeLists.txt 9bf6c68 
>   KTp/Logger/scrollback-manager.h PRE-CREATION 
>   KTp/Logger/scrollback-manager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113836/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131114/7dbce462/attachment.html>