Review Request 109771: Fix set of spell cheking language during configuration loading

[Eugene Shalygin]

> On March 28, 2013, 11:57 a.m., Commit Hook wrote:
> > This review has been submitted with commit 57de7ad0583392f1ef533d2fffa5b0b2897b5c02 by David Edmundson on behalf of Eugene Shalygin to branch master.

Thank you!


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109771/#review29994
-----------------------------------------------------------


On March 28, 2013, 11:57 a.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109771/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 11:57 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> KTextEdit::setSpellCheckingLanguage() does not do anything if there is no highlighter created yet, and KTextEdit::setCheckSpellingEnabled() does not create it if there is no focus on widget. Therefore 
> d->ui.sendMessageBox->setSpellCheckingLanguage() call in ChatWidget::loadSpellCheckingOption() is ignored. While this looks like KTextEditor bug (espesially taking into account its documentation), just a call to KTextEditor::createHighlighter() before setting language fixes this.
> 
> And I moved loadSpellCheckingOption() because createHighlighter() results in ChatWidget::onInputBoxChanged() call, where timers are used.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp 8df51c1 
> 
> Diff: http://git.reviewboard.kde.org/r/109771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130328/e2b6fa79/attachment.html>