<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109771/">http://git.reviewboard.kde.org/r/109771/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 28th, 2013, 11:57 a.m. UTC, <b>Commit Hook</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 57de7ad0583392f1ef533d2fffa5b0b2897b5c02 by David Edmundson on behalf of Eugene Shalygin to branch master.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you!</pre>
<br />
<p>- Eugene</p>
<br />
<p>On March 28th, 2013, 11:57 a.m. UTC, Eugene Shalygin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Eugene Shalygin.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 11:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KTextEdit::setSpellCheckingLanguage() does not do anything if there is no highlighter created yet, and KTextEdit::setCheckSpellingEnabled() does not create it if there is no focus on widget. Therefore
d->ui.sendMessageBox->setSpellCheckingLanguage() call in ChatWidget::loadSpellCheckingOption() is ignored. While this looks like KTextEditor bug (espesially taking into account its documentation), just a call to KTextEditor::createHighlighter() before setting language fixes this.
And I moved loadSpellCheckingOption() because createHighlighter() results in ChatWidget::onInputBoxChanged() call, where timers are used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/chat-widget.cpp <span style="color: grey">(8df51c1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109771/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>