Review Request 109771: Fix set of spell cheking language during configuration loading

Commit Hook null at kde.org
Thu Mar 28 11:57:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109771/
-----------------------------------------------------------

(Updated March 28, 2013, 11:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

KTextEdit::setSpellCheckingLanguage() does not do anything if there is no highlighter created yet, and KTextEdit::setCheckSpellingEnabled() does not create it if there is no focus on widget. Therefore 
d->ui.sendMessageBox->setSpellCheckingLanguage() call in ChatWidget::loadSpellCheckingOption() is ignored. While this looks like KTextEditor bug (espesially taking into account its documentation), just a call to KTextEditor::createHighlighter() before setting language fixes this.

And I moved loadSpellCheckingOption() because createHighlighter() results in ChatWidget::onInputBoxChanged() call, where timers are used.


Diffs
-----

  lib/chat-widget.cpp 8df51c1 

Diff: http://git.reviewboard.kde.org/r/109771/diff/


Testing
-------


Thanks,

Eugene Shalygin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130328/9bd1c706/attachment.html>


More information about the KDE-Telepathy mailing list