Review Request 109563: Rewrite avatarPixmap() to use pixmap cache, simplifies code

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109563/#review29591
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On March 18, 2013, 11:40 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109563/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 11:40 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The previous code stored things in pixmap cache but didn't really load them. This stores all avatars in pixmap cache and first checks if the cache has avatar for us, only if not proceeds to actually load things.
> 
> 
> Diffs
> -----
> 
>   KTp/contact.cpp 33ab04f 
>   KTp/contact.h 5eea8c1 
> 
> Diff: http://git.reviewboard.kde.org/r/109563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130320/6cfb4ddf/attachment.html>