Review Request 109563: Rewrite avatarPixmap() to use pixmap cache, simplifies code

Martin Klapetek martin.klapetek at gmail.com
Mon Mar 18 11:40:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109563/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

The previous code stored things in pixmap cache but didn't really load them. This stores all avatars in pixmap cache and first checks if the cache has avatar for us, only if not proceeds to actually load things.


Diffs
-----

  KTp/contact.cpp 33ab04f 
  KTp/contact.h 5eea8c1 

Diff: http://git.reviewboard.kde.org/r/109563/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130318/3afcf2e4/attachment-0001.html>


More information about the KDE-Telepathy mailing list