Review Request 109563: Rewrite avatarPixmap() to use pixmap cache, simplifies code

Commit Hook null at kde.org
Wed Mar 20 19:55:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109563/#review29592
-----------------------------------------------------------


This review has been submitted with commit e9d7007f184bba5cd37e06edac59d7dffdbf93b4 by Martin Klapetek to branch master.

- Commit Hook


On March 18, 2013, 11:40 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109563/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 11:40 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The previous code stored things in pixmap cache but didn't really load them. This stores all avatars in pixmap cache and first checks if the cache has avatar for us, only if not proceeds to actually load things.
> 
> 
> Diffs
> -----
> 
>   KTp/contact.cpp 33ab04f 
>   KTp/contact.h 5eea8c1 
> 
> Diff: http://git.reviewboard.kde.org/r/109563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130320/dc6aa186/attachment-0001.html>


More information about the KDE-Telepathy mailing list