Review Request 109182: Make Message store sender and MessageProcessor take arbitrary filters

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109182/
-----------------------------------------------------------

(Updated March 2, 2013, 6:32 a.m.)


Review request for Telepathy.


Changes
-------

Okay, ditch MessageItem and replace it with KTp::Message instead.
Add methods for senderName() and senderId() - someone else can deal with the stupid KTp::ContactPtr!

Oh, also fix a bug where the timestamp wasn't set correctly in the Tp::ReceivedMessage constructor.


Description
-------

This is the accompanying patch to https://git.reviewboard.kde.org/r/109181/.

It makes KTp::Messages store sender details as properties (to be used to send the notification). 

It also adds two methods to KTp::MessageProcessor to append/remove filters. I did this as a quick hack to allow me to test the NotifyFilter. I think we'll have to make KTp::MessageFilter a non singleton class and have it implicitly share the loaded plugins list between instances.


This addresses bug 315790.
    http://bugs.kde.org/show_bug.cgi?id=315790


Diffs (updated)
-----

  KTp/Declarative/messages-model.cpp dc975d0 
  KTp/message.h 240e498 
  KTp/message.cpp 7be60e0 

Diff: http://git.reviewboard.kde.org/r/109182/diff/


Testing
-------

Same as the other patch.


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130302/dcb5b520/attachment.html>