Review Request 109182: Replace MessageItem with KTp::Message
Lasath Fernando
kde at lasath.org
Sat Mar 2 06:33:04 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109182/
-----------------------------------------------------------
(Updated March 2, 2013, 6:33 a.m.)
Review request for Telepathy.
Summary (updated)
-----------------
Replace MessageItem with KTp::Message
Description
-------
This is the accompanying patch to https://git.reviewboard.kde.org/r/109181/.
It makes KTp::Messages store sender details as properties (to be used to send the notification).
It also adds two methods to KTp::MessageProcessor to append/remove filters. I did this as a quick hack to allow me to test the NotifyFilter. I think we'll have to make KTp::MessageFilter a non singleton class and have it implicitly share the loaded plugins list between instances.
This addresses bug 315790.
http://bugs.kde.org/show_bug.cgi?id=315790
Diffs
-----
KTp/Declarative/messages-model.cpp dc975d0
KTp/message.h 240e498
KTp/message.cpp 7be60e0
Diff: http://git.reviewboard.kde.org/r/109182/diff/
Testing
-------
Same as the other patch.
Thanks,
Lasath Fernando
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130302/2fb2d07a/attachment.html>
More information about the KDE-Telepathy
mailing list