Review Request 109238: Add a class that keeps the latest Tp::ContactPtr for a given contact ID even across reconnections

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109238/#review28367
-----------------------------------------------------------

Ship it!


I like it! Good stuff. Currently I don't see any usages in kpeople, but generally this can be used in the PersonsPresenceModel as-is.


KTp/persistent-contact.h
<http://git.reviewboard.kde.org/r/109238/#comment21183>

    const QString contactId -> const QString &contactId
    
    Also the explicit is not necessary



KTp/persistent-contact.cpp
<http://git.reviewboard.kde.org/r/109238/#comment21184>

    The argument should be Tp::PendingOperation



KTp/persistent-contact.cpp
<http://git.reviewboard.kde.org/r/109238/#comment21182>

    Tp::PendingContacts* -> Tp::PendingContacts *pen...


- Martin Klapetek


On March 1, 2013, 10:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109238/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 10:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a class that keeps track of the latest Tp::ContactPtr for a given contact ID even across reconnections
> 
> --
> This will be used in the pinned-contacts-model (patch not finished) and potentially contact-applet too. 
> 
> Pushing for review now, in case mck182 thinks it would be useful for any kpeople stuff and wants to shape direction of it. We needed something to get 1 contact, this will do that and be completely async.
> 
> I'm not 100% sure on the name, because it's not really like QPersistentModelIndex. Suggestions welcome.
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt a8c86fabec796afb2821c5129e0c105c4a2eea3f 
>   KTp/persistent-contact.h PRE-CREATION 
>   KTp/persistent-contact.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109238/diff/
> 
> 
> Testing
> -------
> 
> None at all :)
> Won't push before it's used in PinnedContactsModel patch.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130301/ce6276bf/attachment-0001.html>