Review Request 111091: Add "Always Ask" option for filetransfer destination directory

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111091/#review34583
-----------------------------------------------------------



src/filetransfer-handler.cpp
<http://git.reviewboard.kde.org/r/111091/#comment25380>

    Even though you want to ask for the folder every time, you probably want to open the download folder configured by the user, so I believe you should always read the entry here...
    Perhaps you can also update the downloadDirectory entry if the user choses another one later...



src/handle-incoming-file-transfer-channel-job.cpp
<http://git.reviewboard.kde.org/r/111091/#comment25384>

    I'd rather use the finished() signal here to keep coherence with the other dialogs



src/handle-incoming-file-transfer-channel-job.cpp
<http://git.reviewboard.kde.org/r/111091/#comment25385>

    Can you move these methods before the chechPartFile? Not really important, but they are kind of in a "temporal" order in which they get called


- Daniele E. Domenichelli


On June 18, 2013, 1:37 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111091/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 1:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implements support for "Always Ask" for filetransfer destination directory option.
> 
> The hack with __k__onDownloadDirectoryCancelled() is necessary because KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted even when "New Folder" button is clicked and handling that would make the code more complicated.
> 
> 
> This addresses bug 295937.
>     http://bugs.kde.org/show_bug.cgi?id=295937
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ebd892c 
>   src/filetransfer-handler.cpp 74c701e 
>   src/handle-incoming-file-transfer-channel-job.h d5e53c4 
>   src/handle-incoming-file-transfer-channel-job.cpp 7a15237 
> 
> Diff: http://git.reviewboard.kde.org/r/111091/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130618/12e651e3/attachment.html>