Review Request 111091: Add "Always Ask" option for filetransfer destination directory

[Dan Vrátil]

> On June 18, 2013, 4:39 p.m., Daniele E. Domenichelli wrote:
> > src/filetransfer-handler.cpp, lines 86-87
> > <http://git.reviewboard.kde.org/r/111091/diff/1/?file=164165#file164165line86>
> >
> >     Even though you want to ask for the folder every time, you probably want to open the download folder configured by the user, so I believe you should always read the entry here...
> >     Perhaps you can also update the downloadDirectory entry if the user choses another one later...

See my reply above. The UI is disabled in KCM when you select "Always Ask", therefore we should ignore it's value.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111091/#review34583
-----------------------------------------------------------


On June 18, 2013, 3:37 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111091/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 3:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implements support for "Always Ask" for filetransfer destination directory option.
> 
> The hack with __k__onDownloadDirectoryCancelled() is necessary because KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted even when "New Folder" button is clicked and handling that would make the code more complicated.
> 
> 
> This addresses bug 295937.
>     http://bugs.kde.org/show_bug.cgi?id=295937
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ebd892c 
>   src/filetransfer-handler.cpp 74c701e 
>   src/handle-incoming-file-transfer-channel-job.h d5e53c4 
>   src/handle-incoming-file-transfer-channel-job.cpp 7a15237 
> 
> Diff: http://git.reviewboard.kde.org/r/111091/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130618/81a6157d/attachment.html>