Review Request 111091: Add "Always Ask" option for filetransfer destination directory

[Dan Vrátil]

> On June 18, 2013, 4:22 p.m., David Edmundson wrote:
> > src/handle-incoming-file-transfer-channel-job.cpp, line 177
> > <http://git.reviewboard.kde.org/r/111091/diff/1/?file=164167#file164167line177>
> >
> >     Should it not default to the directory the user set in the config?
> >     
> >     Doing that kinda complicates the approach you've taken here with using downloadPath.isEmpty() to see if it should prompt or not.

In the UI patch the edit for user-defined directory is disabled (== ignored) when you select "Always Ask", therefor it does not make sense to use it.

I think it should default to QDir::homePath() + "/" + i18n("Downloads"), as in the FileTransferHandler.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111091/#review34580
-----------------------------------------------------------


On June 18, 2013, 3:37 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111091/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 3:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implements support for "Always Ask" for filetransfer destination directory option.
> 
> The hack with __k__onDownloadDirectoryCancelled() is necessary because KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted even when "New Folder" button is clicked and handling that would make the code more complicated.
> 
> 
> This addresses bug 295937.
>     http://bugs.kde.org/show_bug.cgi?id=295937
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ebd892c 
>   src/filetransfer-handler.cpp 74c701e 
>   src/handle-incoming-file-transfer-channel-job.h d5e53c4 
>   src/handle-incoming-file-transfer-channel-job.cpp 7a15237 
> 
> Diff: http://git.reviewboard.kde.org/r/111091/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130618/9762023d/attachment-0001.html>