Review Request 111514: Make %time translatable and improve the related strings

[Lasse Liehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111514/
-----------------------------------------------------------

(Updated July 16, 2013, 10:14 a.m.)


Review request for Telepathy.


Changes
-------

Sure. Updated to store the translation in a member variable because it is used in more than one member function.


Description
-------

It was unclear whether "%time" was translatable in the strings. Also all of them said "time of when you went away" even though that isn't the case for two of the messages.


Diffs (updated)
-----

  config/telepathy-kded-config.h 166338f 
  config/telepathy-kded-config.cpp 462dd38 

Diff: http://git.reviewboard.kde.org/r/111514/diff/


Testing
-------

Compiles and checked with a placeholder translation installed that the "translation" is shown in the UI while the untranslated value is stored in the config file.


Thanks,

Lasse Liehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130716/6ed4bec9/attachment.html>