Review Request 111514: Make %time translatable and improve the related strings

David Edmundson david at davidedmundson.co.uk
Tue Jul 16 15:13:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111514/#review36052
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On July 16, 2013, 10:14 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111514/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 10:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It was unclear whether "%time" was translatable in the strings. Also all of them said "time of when you went away" even though that isn't the case for two of the messages.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.h 166338f 
>   config/telepathy-kded-config.cpp 462dd38 
> 
> Diff: http://git.reviewboard.kde.org/r/111514/diff/
> 
> 
> Testing
> -------
> 
> Compiles and checked with a placeholder translation installed that the "translation" is shown in the UI while the untranslated value is stored in the config file.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130716/c6df4121/attachment.html>


More information about the KDE-Telepathy mailing list