Review Request 111514: Make %time translatable and improve the related strings

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111514/#review36017
-----------------------------------------------------------

Ship it!



config/telepathy-kded-config.cpp
<http://git.reviewboard.kde.org/r/111514/#comment26652>

    is it better to only do this once, and save the translated string?
    
    i.e 
    
    QString translatedTimeToken = i18n(%time)
    
    ui->m_awayMessage->setText(awayMessage.replace("%time", translatedTimeToken))
    
    for all 3 bits of code use that, rather than translating it 3 times.


- David Edmundson


On July 15, 2013, 11:56 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111514/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 11:56 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It was unclear whether "%time" was translatable in the strings. Also all of them said "time of when you went away" even though that isn't the case for two of the messages.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 462dd38 
> 
> Diff: http://git.reviewboard.kde.org/r/111514/diff/
> 
> 
> Testing
> -------
> 
> Compiles and checked with a placeholder translation installed that the "translation" is shown in the UI while the untranslated value is stored in the config file.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130716/e8c4763b/attachment-0001.html>