Review Request: Fix TelepathyGlib deprecated warnings

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108157/#review24982
-----------------------------------------------------------

Ship it!


I tried to review this once, and RB lost my comments. Then I rage quit.

I don't think it's worth applying to stable with #ifdefs. More problems than it's worth, especially considering the deprecated function isn't removed. 

For master, this is awesome. ++

- David Edmundson


On Jan. 4, 2013, 11:30 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108157/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 11:30 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Starting with TelepathyGlib 0.16 tp_account_manager_ensure_account and tp_account_manager_prepare_async are deprecated in favor of tp_simple_client_factory_ensure_account and tp_proxy_prepare_async
> 
> I was thinking to commit this in 0.5 branch as well, but I'm not sure, since it require to bump telepathy-glib version from 0.13 to 0.16, perhaps using some #ifdef we could do the trick and keep 0.13, but I'm not sure if it is worth. What do you think?
> 
> 
> This addresses bug 304846.
>     http://bugs.kde.org/show_bug.cgi?id=304846
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b88e06e2a28d77400bfa5480e02cfdce34482891 
>   TelepathyLoggerQt4/pending-dates.cpp 089b7c25f5530711c843614126511d12af2cc66a 
>   TelepathyLoggerQt4/pending-entities.cpp 9a2a7350506059c76cea34b74fca624112d55e54 
>   TelepathyLoggerQt4/pending-events.cpp cc5909a67830f16389476eba121849cb725d7bf0 
>   TelepathyLoggerQt4/utils.cpp 2a312777fa3453922e41a54e66afac5a923f3742 
> 
> Diff: http://git.reviewboard.kde.org/r/108157/diff/
> 
> 
> Testing
> -------
> 
> Built and run ktp-text-ui and ktp-log-viewer
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130108/5642036c/attachment.html>