<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108157/">http://git.reviewboard.kde.org/r/108157/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to review this once, and RB lost my comments. Then I rage quit.
I don't think it's worth applying to stable with #ifdefs. More problems than it's worth, especially considering the deprecated function isn't removed.
For master, this is awesome. ++</pre>
<br />
<p>- David</p>
<br />
<p>On January 4th, 2013, 11:30 a.m., Daniele E. Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 11:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Starting with TelepathyGlib 0.16 tp_account_manager_ensure_account and tp_account_manager_prepare_async are deprecated in favor of tp_simple_client_factory_ensure_account and tp_proxy_prepare_async
I was thinking to commit this in 0.5 branch as well, but I'm not sure, since it require to bump telepathy-glib version from 0.13 to 0.16, perhaps using some #ifdef we could do the trick and keep 0.13, but I'm not sure if it is worth. What do you think?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and run ktp-text-ui and ktp-log-viewer</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304846">304846</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b88e06e2a28d77400bfa5480e02cfdce34482891)</span></li>
<li>TelepathyLoggerQt4/pending-dates.cpp <span style="color: grey">(089b7c25f5530711c843614126511d12af2cc66a)</span></li>
<li>TelepathyLoggerQt4/pending-entities.cpp <span style="color: grey">(9a2a7350506059c76cea34b74fca624112d55e54)</span></li>
<li>TelepathyLoggerQt4/pending-events.cpp <span style="color: grey">(cc5909a67830f16389476eba121849cb725d7bf0)</span></li>
<li>TelepathyLoggerQt4/utils.cpp <span style="color: grey">(2a312777fa3453922e41a54e66afac5a923f3742)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108157/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>