Review Request: Fix TelepathyGlib deprecated warnings

[Daniele E. Domenichelli]

> On Jan. 8, 2013, 12:06 p.m., Daniele E. Domenichelli wrote:
> > I discussed this with smcv and xclaesse on #telepathy and they confirmed that the patch is ok from the telepathy-glib side.
> > Also they suggested to apply it to master instead of to the stable branch, and to turn off deprecation warnings there, and that seems reasonable to me, so I'd go for it.
> > 
> > So since I'm flagging "Ship It" for myself (because I'm awesome, so I can do it), and I'm going to ship it in a couple of days, unless someone has something against it...
> > 
> > ---
> > 
> > Note for the future me: since tp-glib 0.16 they have 2 macros that are useful for this kind of stuff...
> > "AC_DEFINE(TP_VERSION_MIN_REQUIRED, TP_VERSION_0_16, [Ignore post 0.16 deprecations])" (that becomes a "#define TP_VERSION_MIN_REQUIRED TP_VERSION_0_16")
> > "AC_DEFINE(TP_VERSION_MAX_ALLOWED, TP_VERSION_0_16, [Prevent post 0.16 APIs])" (that becomes a "#define TP_VERSION_MAX_ALLOWED TP_VERSION_0_16")
> > After shipping this patch, I'd like to set TP_VERSION_MIN_REQUIRED...
> 
> David Edmundson wrote:
>     Why would we turn off deprecation warnings on master now that we've fixed it?

In case in telepathy-glib newer version deprecate something that it is used in there. But yes, this makes no sense on master, I'd rather apply it just before tagging and branching stable versions, so that on stable releases we never get these deprecation warnings...


- Daniele E.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108157/#review24973
-----------------------------------------------------------


On Jan. 4, 2013, 11:30 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108157/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 11:30 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Starting with TelepathyGlib 0.16 tp_account_manager_ensure_account and tp_account_manager_prepare_async are deprecated in favor of tp_simple_client_factory_ensure_account and tp_proxy_prepare_async
> 
> I was thinking to commit this in 0.5 branch as well, but I'm not sure, since it require to bump telepathy-glib version from 0.13 to 0.16, perhaps using some #ifdef we could do the trick and keep 0.13, but I'm not sure if it is worth. What do you think?
> 
> 
> This addresses bug 304846.
>     http://bugs.kde.org/show_bug.cgi?id=304846
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b88e06e2a28d77400bfa5480e02cfdce34482891 
>   TelepathyLoggerQt4/pending-dates.cpp 089b7c25f5530711c843614126511d12af2cc66a 
>   TelepathyLoggerQt4/pending-entities.cpp 9a2a7350506059c76cea34b74fca624112d55e54 
>   TelepathyLoggerQt4/pending-events.cpp cc5909a67830f16389476eba121849cb725d7bf0 
>   TelepathyLoggerQt4/utils.cpp 2a312777fa3453922e41a54e66afac5a923f3742 
> 
> Diff: http://git.reviewboard.kde.org/r/108157/diff/
> 
> 
> Testing
> -------
> 
> Built and run ktp-text-ui and ktp-log-viewer
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130109/14f324a1/attachment-0001.html>