Review Request 109004: Improve TplQt4 CMakeLists.txt

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109004/#review27627
-----------------------------------------------------------

Ship it!


Nice, I wanted to clean the build system of tpl-qt4 for a long time now, but didn't get around to it. There are also lots of other things to fix (you can see that the whole thing is a bloated pack of old cmake code, which was copied blindly from tp-qt and doesn't make much sense). Ship it when you fix the issues below.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/109004/#comment20711>

    Get rid of that



CMakeLists.txt
<http://git.reviewboard.kde.org/r/109004/#comment20709>

    Python is not part of Qt-Project



CMakeLists.txt
<http://git.reviewboard.kde.org/r/109004/#comment20708>

    Wrong information. QtGLib is Qt bindings for GLib, part of QtGStreamer, and it is needed everywhere in TplQt4



CMakeLists.txt
<http://git.reviewboard.kde.org/r/109004/#comment20710>

    Get rid of that


- George Kiagiadakis


On Feb. 18, 2013, 11:39 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109004/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 11:39 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
>  1) Fix version check for telepathy-logger - cmake will now correctly fail if telepathy-logger>=0.8.0 is not available
>  2) Use set_package_properties() macro to nicely log optional/required/missing packages
> 
> (Using set_package_properties() requires at CMake>=2.8.6, but since kdepimlibs already require it for 4.10, it should not cause any trouble)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a2d457a 
>   cmake/modules/FindDBusGLib.cmake af4bbe8 
>   cmake/modules/FindQtGLib.cmake 0713164 
>   codegen/CMakeLists.txt bcf3ffe 
> 
> Diff: http://git.reviewboard.kde.org/r/109004/diff/
> 
> 
> Testing
> -------
> 
> Still compiles
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130218/1332feb0/attachment.html>